refactor: Be more selective in eslint ignorance #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than ignoring blockly_uncompressed.js, gulpfile.js and core/utils/global.js entirely, add suitable eslint-disable directives to those files so that they lint cleanly (and migrate gulpfile to use const instead of var).
cpcallen
added
component: build process
PR: chore
gonfunko
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Rather than ignoring
blockly_uncompressed.js,gulpfile.jsandcore/utils/global.jsentirely, add suitableeslint-disabledirectives to those files so that they lint cleanly (and migrategulpfile.jsto useconstinstead ofvar).Behaviour Before Change
Lints cleanly.
Behavior After Change
Lints more stuff cleanly.
Reason for Changes
Catch other (future) lint in these files.
Test Coverage
npm run lintcompletes successfully.